New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GitHub links in tests/README.md #14631

Merged

tsteur merged 1 commit into matomo-org:3.x-dev from obendev:obendev-patch-2

Jul 5, 2019

Contributor

obendev commented Jul 5, 2019 •

edited

Note:
Two of the links link to a 404. However I didn't remove them, because I didn't know what way you like to handle such a case.

I still think that adjusting these links is right however because /piwik/ will be a 404 someday anyway.


          Update GitHub links in tests/README.md

df78afc

Note:
Two of the links link to a 404. However I didn't remove them, because I didn't know what way you like to handle such a case.
1. https://github.com/matomo-org/matomo/blob/master/tests/PHPUnit/config.ini.travis.php#L23-27 (Line 156)
2. https://github.com/matomo-org/matomo/blob/master/tests/README.xhprof.md (Line 179)
I still think that adjusting these links is right however because /piwik/ will be a 404 sometime anyway.

tsteur merged commit 5887ac5 into matomo-org:3.x-dev

Member

tsteur commented Jul 5, 2019

Thanks again 👍

obendev deleted the obendev-patch-2 branch

July 5, 2019 17:42

mattab added the not-in-changelog label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment