When installer is disabled and any module is requested, also show the not set up yet message #14628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not set up yet message
diosmosis
reviewed
Jul 11, 2019
| @@ -75,6 +76,12 @@ private function checkConfigFileExists($path, $startInstaller = false) | |||
| return; | |||
| } | |||
|
|
|||
| $general = Config::getInstance()->General; | |||
There was a problem hiding this comment.
Does it work to access this here? This could be called before StaticContainer is initialized. Might be better to use $this->settingsProvider.
There was a problem hiding this comment.
@diosmosis done. It worked with the config as well but this way I suppose it is better 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected (already working when requesting https://analytics.domain.com )
but doesn't work when eg requesting https://analytics.domain.com/index.php?module=API&action=home&idSite=1&period=day&date=yesterday
which was showing eg this
Adding another check for this case when a module is specified... In the past we didn't want find a need to fix it but it's easy to do. A test for this special case shouldn't be needed.