Handle ranking query others row properly in contents & events archiver. #14622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
reviewed
Jul 4, 2019
tsteur
reviewed
Jul 4, 2019
|
@tsteur updated. |
tsteur
reviewed
Jul 14, 2019
tsteur
reviewed
Jul 14, 2019
...WithItems_schedrep_html_tables_and_graph__ScheduledReports.generateReport_week.original.html
Outdated
Show resolved
Hide resolved
|
LGTM @diosmosis only need to fix a test in AnonymousUsageMeasurement afterwards see https://travis-ci.org/matomo-org/matomo/jobs/557605365#L809 |
|
There are now also some merge conflicts unfortunately. |
mattab
added
the
c: Performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.