Support to cache the config file #14617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
the
Pull Request WIP
tsteur
added
RFC
tsteur
added
Needs Review
|
As discussed we're wanting to give this a try. |
tsteur
removed
the
RFC
diosmosis
reviewed
Aug 4, 2019
|
|
||
| private function makeCacheDir($host) | ||
| { | ||
| return PIWIK_INCLUDE_PATH . '/tmp/' . $host . '/cache/tracker'; |
There was a problem hiding this comment.
Should we check somewhere if this directory is writable?
There was a problem hiding this comment.
@diosmosis the directory might only be created when actually caching a file (the file backend does that). We already check if PIWIK_INCLUDE_PATH . '/tmp/' is writable as part of the system check not sure if it's enough?
mattab
added
the
c: Performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #14367
This supports caching the config ini file. It would be enabled through
$matomoDir/bootstrap.phpby putting this code in there (we cannot use DI or config file for this because they don't exist at the time of the config loading):It would pretty much only work for single server environments... all others would have the problem that the cache invalidation when the config changes wouldn't be synced. Also we do not want to have to document that users need to invalidate the cache when they make changes to it. It would pretty much only help us and I would probably not even document it. When loaded from a regular filesystem, it should be still very fast with the regular ini. If it works nicely, we could document it eventually.
By caching it, it would come from opcache instead of filesystem... and we would not need to do things like all these decodings etc https://github.com/matomo-org/component-ini/blob/master/src/IniReader.php#L149-L384
Any thoughts on this @mattab
refs DEV-1692