Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If URL starts with // in sites manager, only prepend http: instead of… http:// #14616

Merged
merged 1 commit into from Jul 3, 2019
Merged

If URL starts with // in sites manager, only prepend http: instead of… http:// #14616

merged 1 commit into from Jul 3, 2019

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jul 2, 2019 •
edited

fix #14615

alternatively we could throw an exception if URL starts with //. Configuring a URL with // is not supported currently.

@tsteur
If URL starts with // in sites manager, only prepend http: instead of…
4952ba4 
… http://

fix #14615

alternatively we could throw an exception if URL starts with `//`. Configuring a URL with `//` is not supported currently.
@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jul 2, 2019
@tsteur tsteur added this to the 3.11.0 milestone Jul 2, 2019
@tsteur tsteur changed the title If URL starts with // in sites manager, only prepend http: instead of… If URL starts with // in sites manager, only prepend http: instead of… http:// Jul 2, 2019
@tsteur tsteur mentioned this pull request Jul 2, 2019
Closed
diosmosis
diosmosis approved these changes Jul 3, 2019
View reviewed changes
Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsteur tsteur merged commit 3f57d22 into 3.x-dev Jul 3, 2019
@tsteur tsteur deleted the 14615 branch July 3, 2019 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis diosmosis approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.11.0
Development

Successfully merging this pull request may close these issues.

Bug: Website Measurable URLs unexpected behavior
2 participants
@tsteur @diosmosis