Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Website Measurable URLs unexpected behavior #14615

Closed
Laul0 opened this issue Jul 2, 2019 · 1 comment · Fixed by #14616
Closed

Bug: Website Measurable URLs unexpected behavior #14615

Laul0 opened this issue Jul 2, 2019 · 1 comment · Fixed by #14616
Labels
Bug For errors / faults / flaws / inconsistencies etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone
Backlog (Help wan...

Comments

@Laul0
Copy link

Laul0 commented Jul 2, 2019 •
edited

Summary

During the configuration of the website measurable, you have to specify one or several URLs.

Current behavior

If I specify an URL like https://mysite.com, everything is ok.

But, if I use an URL like //mysite.com to avoid specify https:// or http://:

  • from All Websites page, Visits and pageviews keep working and increment values
  • No Widgets from the Dashboard display new values (ex: real time count still at 0)
  • When I come back to the configuration, the URL become ////mysite.com

Expected/desired behavior

First scenario

Display an error message if the URL is not valid (URL validator)

Second scenario

Allow to use URLs that begin by // (without https or http) and support them into data incrementation.
@tsteur tsteur added Bug For errors / faults / flaws / inconsistencies etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. labels Jul 2, 2019
@tsteur tsteur added this to the Backlog (Help wanted) milestone Jul 2, 2019
tsteur added a commit that referenced this issue Jul 2, 2019
@tsteur
If URL starts with // in sites manager, only prepend http: instead of…
4952ba4 
… http://

fix #14615

alternatively we could throw an exception if URL starts with `//`. Configuring a URL with `//` is not supported currently.
@tsteur tsteur mentioned this issue Jul 2, 2019
Merged
@tsteur
Copy link
Member

tsteur commented Jul 2, 2019

Cheers for the report, we'll only prepend http: instead of https:// in the future: #14616

Specifying //foo.com is not supported unfortunately. You could instead configure multiple urls with http://... and https://. In https://github.com/matomo-org/matomo/blob/3.10.0/plugins/WebsiteMeasurable/Settings/Urls.php#L89 we are checking the URL looks valid but it was not requiring a scheme.

tsteur added a commit that referenced this issue Jul 3, 2019
@tsteur
If URL starts with // in sites manager, only prepend http: instead of…
3f57d22 
… http:// (#14616)

fix #14615

alternatively we could throw an exception if URL starts with `//`. Configuring a URL with `//` is not supported currently.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

Successfully merging a pull request may close this issue.

If URL starts with // in sites manager, only prepend http: instead of… http:// matomo-org/matomo
2 participants
@tsteur @Laul0