Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify Always block and Never block precedence in UI or FAQ #14610

Closed
mattab opened this issue Jul 2, 2019 · 1 comment
Closed

Clarify Always block and Never block precedence in UI or FAQ #14610

mattab opened this issue Jul 2, 2019 · 1 comment
Labels
answered For when a question was asked and we referred to forum or answered it.
Milestone
3.11.0

Comments

@mattab
Copy link
Member

mattab commented Jul 2, 2019

We got this feedback on our FAQ: How do I disable brute force authentication security checks for specific IP addresses?

The page (and documentation) are unclear that (it seems) "Always block" takes priority over "Never block" rules.

I specified 0.0.0.0/0 in "Always block" and then entered a list of trusted IPs in "Never block"; now the UI is blocking me and I came here trying to find out how/where to reset that erroneous setting (e.g. in what database table or config file).

I haven't checked, but can we verify if there is maybe a bug or something that could be improved in the inline help or so?
@mattab mattab added the c: Usability For issues that let users achieve a defined goal more effectively or efficiently. label Jul 2, 2019
@mattab mattab added this to the 3.12.0 milestone Jul 2, 2019
@mattab mattab changed the title Clarify Clarify Always block and Never block precedence in UI or FAQ Jul 2, 2019
@tsteur
Copy link
Member

tsteur commented Jul 18, 2019

We're definitely first blocking, then allowing as the user describes. I suppose sometimes you want it maybe this way, sometimes another way?

What the user wants to achieve seems actually more like the login_whitelist_ip feature where you can configure to only allow the log in for certain IPs see https://matomo.org/faq/how-to/faq_25543/

@tsteur tsteur closed this as completed Jul 18, 2019
@tsteur tsteur added answered For when a question was asked and we referred to forum or answered it. and removed c: Usability For issues that let users achieve a defined goal more effectively or efficiently. labels Jul 18, 2019
@mattab mattab modified the milestones: 3.13.0, 3.11.0 Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
answered For when a question was asked and we referred to forum or answered it.
Projects
None yet
Milestone
3.11.0
Development

No branches or pull requests
2 participants
@tsteur @mattab