New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Freeze left-hand column of data table #14594
Conversation
There are at least two issues:
|
The first column in the |
We need the first column in the |
Now using |
For safari you can use |
The labels are very wide when the datatable is quite wide but doesn't have many columns (e.g. on the Goals Overview page, or the Search Categories report on the Site Search page). This is due to the datatable itself taking up 100% of the available width, then calculating how much the data columns need and assigning all of the excess to the label column. Not sure what the best approach here is, should we try to spread the width more evenly over the columns or should we reduce the width of the datatable? |
Have tested successfully in Chrome/Firefox/Edge on Windows, Safari on MacOS, Safari on iOS, Chrome/Firefox on Android. Fails gracefully with IE or Safari on Windows, reverting to current behaviour where the whole datatable scrolls. |
@katebutler looking great! Noticed on issue which you can also see here: https://github.com/matomo-org/matomo/pull/14594/files?short_path=c74ac3c#diff-570cf8d0cd615f4d8f62314cf92bed8a There are sometimes some row action icons missing, eg the row evolution. When I highlight the element, I noticed there's not enough space so it shows some icons in a "new line" I think and therefore isn't visible. Before it would have probably simply "overflown" it and shown it in the next column. When I lower here the margin-left and set it to say 284px, then all the row icons become visible: |
…n this branch) to avoid merge conflicts
# Conflicts: # plugins/Dashboard/tests/UI/expected-screenshots/DashboardManager_removed.png # plugins/Dashboard/tests/UI/expected-screenshots/Dashboard_loaded_token_auth.png # plugins/Dashboard/tests/UI/expected-screenshots/Dashboard_removed.png # tests/UI/expected-screenshots/PivotByDimension_pivoted_columns_report.png # tests/UI/expected-screenshots/Theme_home.png # tests/UI/expected-screenshots/UIIntegrationTest_dashboard1.png # tests/UI/expected-screenshots/UIIntegrationTest_ecommerce_sales.png
@katebutler there are a few more failing ui tests before we can merge: https://builds-artifacts.matomo.org/matomo-org/matomo/3.x-dev/35329/ Maybe we only need to update the expected screenshots? |
Apart from this looks good 👍 |
Awesome @katebutler 💯 |
Fixes #14333