Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid using group by and select min for tracker actions query to avoid tmp tables refs #14535 #14584

Merged
merged 1 commit into from Jul 5, 2019
Merged

avoid using group by and select min for tracker actions query to avoid tmp tables refs #14535 #14584

merged 1 commit into from Jul 5, 2019

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jun 28, 2019

The tests passed for me locally. Be good if someone can confirm this will end up being the same logic.

refs #14535

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jun 28, 2019
@tsteur tsteur added this to the 3.11.0 milestone Jun 28, 2019
@tsteur tsteur mentioned this pull request Jun 28, 2019
Closed
@tsteur
Copy link
Member Author

tsteur commented Jun 28, 2019

@diosmosis @mattab could you both have a look at this ideally?

@diosmosis
Copy link
Member

Looks ok to me

@tsteur tsteur merged commit aed8c10 into 3.x-dev Jul 5, 2019
@tsteur tsteur deleted the 14535 branch July 5, 2019 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.11.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @diosmosis