Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate very long useragents to prevent possible tracking slowdown #14581

Merged
merged 2 commits into from Jul 3, 2019

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jun 27, 2019

No description provided.

@sgiehl sgiehl added the Needs Review PRs that need a code review label Jun 27, 2019
@tsteur
Copy link
Member

tsteur commented Jun 28, 2019

Changed it to Common::mb_substr. Looks good to me if tests pass and could include it in 3.10 I suppose. Or in 3.11...

@tsteur tsteur merged commit 8b7b4b2 into 3.x-dev Jul 3, 2019
@tsteur tsteur deleted the limituseragent branch July 3, 2019 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants