Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS Tracker: add rtf to list of downloads #14579

Closed
jaapvandeputte opened this issue Jun 27, 2019 · 5 comments · Fixed by #15975
Closed

JS Tracker: add rtf to list of downloads #14579

jaapvandeputte opened this issue Jun 27, 2019 · 5 comments · Fixed by #15975
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.

Comments

@jaapvandeputte
Copy link

Hi there,

I'm new here so sorry when I'm mistaken in any etiquette.

I have a little question: is it possible Matomo as default adds rtf to the list of downloads? I know I can add this with a line of javascript, but it's a bit easier when that is already there.
@jaapvandeputte
Copy link
Author

And docx, xlsx and pptx too, as they are often used?

@sgiehl
Copy link
Member

sgiehl commented Jun 27, 2019

you can see the full list here:

matomo/js/piwik.js

Line 3065 in 7a93a2b

configDownloadExtensions = ['7z','aac','apk','arc','arj','asf','asx','avi','azw3','bin','csv','deb','dmg','doc','docx','epub','exe','flv','gif','gz','gzip','hqx','ibooks','jar','jpg','jpeg','js','mobi','mp2','mp3','mp4','mpg','mpeg','mov','movie','msi','msp','odb','odf','odg','ods','odt','ogg','ogv','pdf','phps','png','ppt','pptx','qt','qtm','ra','ram','rar','rpm','sea','sit','tar','tbz','tbz2','bz','bz2','tgz','torrent','txt','wav','wma','wmv','wpd','xls','xlsx','xml','z','zip'],

It already includes docx, pptx, xlsx. Feel free to create a PR to add rtf to that list.

@tsteur tsteur added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Jun 27, 2019
@jaapvandeputte
Copy link
Author

@sgielh: thanks, I have been using an old list. Good to hear that docx pptx xlsx are on the list. Can you please explain what an PO is and how I can create this?

@sgiehl
Copy link
Member

sgiehl commented Jul 1, 2019

@jaapvandeputte I meant opening a Pull Request here on github

@mattab mattab changed the title Add rtf to list of downloads JS Tracker: add rtf to list of downloads Jan 21, 2020
@mattab mattab added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Jan 21, 2020
@mattab
Copy link
Member

mattab commented Jan 21, 2020

@jaapvandeputte please see how to do this in: https://developer.matomo.org/guides/contributing-to-piwik-core#contribution-process

@Findus23 Findus23 mentioned this issue May 23, 2020
Merged
@Findus23 Findus23 removed the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add .rtf to download filetypes matomo-org/matomo
5 participants
@tsteur @mattab @sgiehl @Findus23 @jaapvandeputte