Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random failing integration test: 1) Piwik\Plugins\SEO\tests\Integration\SEOTest::test_API google-index expected non-zero rank, got [0] #14577

Closed
mattab opened this issue Jun 27, 2019 · 2 comments · Fixed by #14643
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Jun 27, 2019

There is a regularly randomly failing integration test:

1) Piwik\Plugins\SEO\tests\Integration\SEOTest::test_API
google-index expected non-zero rank, got [0]
Failed asserting that a integer is not empty.
/home/travis/build/matomo-org/matomo/plugins/SEO/tests/Integration/SEOTest.php:61

seen for example in https://travis-ci.org/matomo-org/matomo/jobs/550650396

is there maybe a way to avoid this random failure? (maybe it would help to re-try after 10 seconds when it fails, but probably won't be enough to fix the issue)

@mattab mattab added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Jun 27, 2019
@mattab mattab added this to the 3.12.0 milestone Jun 27, 2019
@Findus23
Copy link
Member

Investigating this was already on my todo, but I wouldn't be surprised if this is just the fact that the Google SEO integration is basically broken: #12248

@Findus23
Copy link
Member

I guess the best "solution" would just be ignoring that test and making it not fail the whole build.

@mattab mattab modified the milestones: 3.13.0, 3.11.0 Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants