Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow site selector dropdown to grow wider for websites with long names #14576

Merged
merged 3 commits into from Jul 9, 2019

Conversation

katebutler
Copy link

@katebutler katebutler commented Jun 26, 2019

Fixes #13706

@katebutler katebutler added the Needs Review PRs that need a code review label Jun 26, 2019
@katebutler katebutler added this to the 3.11.0 milestone Jun 26, 2019
@tsteur
Copy link
Member

tsteur commented Jul 5, 2019

Works. On mobile it can get maybe too wide but I suppose that's not an issue.
image

Let's merge it for now and tweak again later if needed.

@tsteur
Copy link
Member

tsteur commented Jul 5, 2019

@katebutler can you fix the failing UI test (https://builds-artifacts.matomo.org/matomo-org/matomo/3.x-dev/34693/) and then merge? There seem to be 3 site selector screenshots changed.

@katebutler katebutler merged commit 950e7c7 into 3.x-dev Jul 9, 2019
@mattab mattab deleted the 13706 branch July 9, 2019 23:10
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand drop down menu list when searching for a site and make it so that you can see the full title.
4 participants