JS Tracker: URL Custom Dimension values to prevent Error 400 issue on IE11 when dimension values include non ascii characters #14566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…non ascii characters Issue found & Patch suggested by Customer
|
Be great if you can review & check tests pass & merge this in 3.10.0 @diosmosis @tsteur as the bug is causing JS errors in IE11 when custom dimension values have non ascii characters. |
|
If a user is currently using this w/ encoded parameters can they encode the parameter values themselves to workaround this? And if so, would this change break that use? |
|
@mattab JS tests are passing now |
mattab
changed the title
mattab
added
the
Major
mattab
added a commit
that referenced
this pull request
Jul 1, 2019
mattab
added a commit
that referenced
this pull request
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue found & Patch suggested by Customer