Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Galaxy S9 shows as duplicate in reports (the ending %2B is not correctly displayed) #14564

Closed
mattab opened this issue Jun 24, 2019 · 3 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.

Comments

@mattab
Copy link
Member

mattab commented Jun 24, 2019

Reported by email:

I have multiple entries for the GALAXY S9.

See screenshot:

Screenshot from 2019-05-24 18-30-10

In the UI it looks like this:

Screenshot from 2019-05-24 18-31-54

Likely an encoding issue where the ending %2B is not displayed correctly in the reports?

@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Jun 24, 2019
@mattab mattab added this to the 3.12.0 milestone Jun 24, 2019
@sgiehl
Copy link
Member

sgiehl commented Jul 2, 2019

I have investigated the issue. The data is correctly tracked and also correctly included in the resulting datatable returned by the API method. The problem is a result of the SafeDecodeLabel filter that is applied to in the DataTablePostProcessor, which does a urldecode on all lables. As the device name includes a +, it's converted to a .

@mattab @tsteur @diosmosis does anyone have a good idea how to tackle that? Removing the SafeDecodeLabel might have various side effects. Also there might be labels containing a + that should be converted to a space 🤷‍♂️

@diosmosis
Copy link
Member

This is a similar problem I tried to solve here: #13481

Every change I made resulted in a new broken test, haven't worked on it in a while.

@mattab mattab modified the milestones: 3.13.0, 4.1.0 Oct 30, 2019
@mattab mattab modified the milestones: 4.1.0, 4.2.0 Dec 21, 2020
@mattab mattab modified the milestones: 4.2.0, 4.3.0 Feb 22, 2021
@mattab mattab modified the milestones: 4.3.0, 4.4.0 May 26, 2021
@mattab
Copy link
Member Author

mattab commented Dec 11, 2023

As it has been a few months since the last activity and we believe this is likely not an issue anymore, we will now close this. If that's not the case, please do feel free to either reopen this issue or open a new one. We will gladly take a look again!

@mattab mattab closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

4 participants