@sgiehl opened this Pull Request on June 23rd 2019 Member

fixes #14517

@diosmosis commented on June 25th 2019 Member

Works for me. Only thing that worries me is if some error occurs and _destroy() isn't called. This would result in the period selector being hidden, which could be an annoying bug to track down.

@sgiehl commented on June 25th 2019 Member
@diosmosis commented on June 30th 2019 Member

Huh, I would expect that might cause problems w/ this change actually, since I think the event is never removed from $rootScope?

@sgiehl commented on July 1st 2019 Member

I actually didn't have problems with that while testing. Guess the piwikPageChange event is triggered before the widgets are created or destroyed.
I'll try to implement something else, that simplifies both implementations....

@sgiehl commented on July 1st 2019 Member

@diosmosis tried to improve & simplify the code. Could you have another look?

This Pull Request was closed on July 5th 2019
Powered by GitHub Issue Mirror