@sgiehl opened this Issue on July 2nd 2010 Member

It is nice, that it's adjustable to sort the API-responses as needed.
Is there a reason why _filter_sortcolumn and _filter_sortorder have both to be given in a request to get it sorted. I would expect that sorting a column without a given order behaves like any database and orders asc by default.

It's not realy a bug, but i just wondered why sorting didn't apply without _filter_sortorder.

I guess it's easy to change this. Giving a default value for _filter_sortorder in core/API/DataTableGenericFilter.php should fix it.
Keywords: API sorting order

@mattab commented on July 12th 2010 Member

sounds good, but filter_sort_order should default to 'desc' in our case

@sgiehl commented on July 12th 2010 Member

(In [2481]) fixes #1456 added default sorting order (desc) if filter_sort_order is not given

@mattab commented on July 12th 2010 Member

(In [2484]) Refs #1456

Fixing failing integration tests now that Sort filter is called by default with 'desc'.

Note: to fix integration tests, compare tests/integration/processed and tests/integration/expected/ with a file compare tool (like WinMerge on windows). If it looks good, copy processed/* files over the expected/* and tests will pass.

This Issue was closed on July 12th 2010
Powered by GitHub Issue Mirror