Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new translation keys for mobile app #14550

Merged
merged 2 commits into from Jun 23, 2019
Merged

Add new translation keys for mobile app #14550

merged 2 commits into from Jun 23, 2019

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jun 20, 2019

See matomo-org/matomo-mobile-2#5344 (comment) except for Mobile_PossibleSslErrorExplanation2 which isn't used currently

@tsteur
Add new translation keys for mobile app
a92b18a 
See matomo-org/matomo-mobile-2#5344 (comment) except for `Mobile_PossibleSslErrorExplanation2 ` which isn't used  currently
@tsteur tsteur added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Jun 20, 2019
@tsteur tsteur added this to the 3.11.0 milestone Jun 20, 2019
@tsteur tsteur mentioned this pull request Jun 20, 2019
Merged
sgiehl
sgiehl reviewed Jun 20, 2019
View reviewed changes
lang/en.json Outdated Show resolved Hide resolved
sgiehl
sgiehl approved these changes Jun 23, 2019
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Could also be merged for 3.10 I guess, as it doesn't affect core in any way...

@tsteur tsteur merged commit b49ffb2 into 3.x-dev Jun 23, 2019
@tsteur tsteur deleted the mobileapptranslationkeys branch June 23, 2019 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.11.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @sgiehl