@mattab opened this Issue on June 19th 2019 Member

WARNING: www/demo.piwik.org/core/Piwik.php(122): Warning - A non-numeric value encountered - Matomo 3.10.0-rc1 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already)

@fdellwing commented on June 19th 2019 Contributor

https://github.com/matomo-org/matomo/blob/4fc073e863c97bbb699213561d8d1c5c16c76792/core/Piwik.php#L120-L123

I searched the log for newly added or changed calls to this function, but was not able to find anything recent. So it might be a side effect of another change.

git log -SgetPercentageSafe -- .
git log -GgetPercentageSafe -- .
@mattab commented on June 27th 2019 Member

Again got the error on demo where it was displayed 10 times in a row... this may affect all users, not sure... Could we maybe add a silent fail in front of it? or throw an exception (may cause some feature of Matomo to fail)? @diosmosis @tsteur

@Findus23 commented on June 27th 2019 Member

@mattab I already though a few times that it might be helpful to add an option that can be temporarily enabled (with a system check urging everyone to disable it again) that will display proper stack traces to all error messages.

That would make debugging far easier as the whole error message people post isn't that helpful in many cases when the php error or warning just occurs in some helper function or in twig.

@tsteur commented on June 28th 2019 Member

It could also be just logged to the file. Such things aren't easy to troubleshoot etc. Best to move this to 3.11

@tsteur commented on October 10th 2019 Member

To find the root cause for these issues better we have changed the file log to include a trace in https://github.com/matomo-org/matomo/pull/14961
So when this issue happens again be good to get a trace and then we can maybe look into this further.

Powered by GitHub Issue Mirror