Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate checking for empty site from checking whether we should do e… #14538

Merged
merged 2 commits into from Jun 20, 2019

Conversation

diosmosis
Copy link
Member

…mpty site check.

@diosmosis diosmosis added the Needs Review PRs that need a code review label Jun 19, 2019
@diosmosis diosmosis added this to the 3.10.0 milestone Jun 19, 2019
@@ -65,6 +65,11 @@ public function redirectDashboardToWelcomePage(&$module, &$action)
return;
}

$shouldPerformEmptySiteCheck = $this->shouldPerormEmptySiteCheck($siteId);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't that be self::shouldPer..?

@@ -88,6 +93,12 @@ public function redirectDashboardToWelcomePage(&$module, &$action)
}

public static function hasTrackedAnyTraffic($siteId)
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method is also used in a task, does it need shouldPerormEmptySiteCheck () there?

@tsteur
Copy link
Member

tsteur commented Jun 20, 2019

@diosmosis haven't tested it but if tests pass looks good to merge 👍

@diosmosis diosmosis merged commit 3519663 into 3.x-dev Jun 20, 2019
@diosmosis diosmosis deleted the should-perform-empty-check branch June 20, 2019 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants