Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy downloaded plugins from Marketplace to MATOMO_PLUGIN_DIRS folder too #14534

Closed
nabiltntn opened this issue Jun 17, 2019 · 1 comment · Fixed by #14537
Closed

Copy downloaded plugins from Marketplace to MATOMO_PLUGIN_DIRS folder too #14534

nabiltntn opened this issue Jun 17, 2019 · 1 comment · Fixed by #14537
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.

Comments

@nabiltntn
Copy link
Contributor

nabiltntn commented Jun 17, 2019 •
edited

Hi,
The new feature allowing different folders for plugins using the MATOMO_PLUGIN_DIRS env is great.

But is it possible to copy downloaded plugins from Marketplace UI also into declared directories in addition to Matomo /plugins folder.

Download logic copies extracted .zip file to '/plugins' folder and it's not using new getPluginsDirectories function

matomo/plugins/CorePluginsAdmin/PluginInstaller.php

Line 52 in 6395855

public function installOrUpdatePluginFromMarketplace($pluginName)

matomo/plugins/CorePluginsAdmin/PluginInstaller.php

Line 68 in 6395855

$this->copyPluginToDestination($tmpPluginFolder);

matomo/plugins/CorePluginsAdmin/PluginInstaller.php

Line 298 in 6395855

private function copyPluginToDestination($tmpPluginFolder)

matomo/plugins/CorePluginsAdmin/PluginInstaller.php

Line 300 in 6395855

$pluginsDir = Manager::getPluginsDirectory();

The goal is to easily "track" all the added/deleted plugins so creating new Matomo deployment becomes much easier.

This is useful with Kubernetes because i can define MATOMO_PLUGIN_DIRS folder to point to a Persistent Volume path shared between many PODs
@tsteur tsteur added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Jun 18, 2019
@tsteur
Copy link
Member

tsteur commented Jun 18, 2019

That would be a new feature. Cause you can configure multiple plugin directories, we wouldn't know where to copy it. We would need a setting for the plugin to be copied somewhere else. Feel free to create a PR for this.

@nabiltntn nabiltntn mentioned this issue Jun 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Copy downloaded plugin to all plugins directories nabiltntn/matomo
2 participants
@nabiltntn @tsteur