Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub links for 'About matomo'-Page (Footer) #14528

Closed
wants to merge 3 commits into from
Closed

Fix GitHub links for 'About matomo'-Page (Footer) #14528

wants to merge 3 commits into from

Conversation

obendev
Copy link
Contributor

@obendev obendev commented Jun 14, 2019

There are still old GitHub links in the footer of the 'About matomo'-Page
I changed them to the new ones, so that there is no unnecessary redirect

There are still old GitHub links in the footer of the 'About matomo'-Page
I changed them to the new ones, so that there is no unnecessary redirect
I also optimized the file size with optipng
@Findus23
Copy link
Member

HI,

Can you maybe remove 0c5d70b? It's a good idea to update those icons, but I think I'll change all of them at once.

Findus23 added a commit that referenced this pull request Jun 14, 2019
Findus23 added a commit that referenced this pull request Jun 14, 2019
@Findus23 Findus23 mentioned this pull request Jun 14, 2019
@obendev
Copy link
Contributor Author

obendev commented Jun 14, 2019

Hey @Findus23 I didn't even knew it automatically committed this one in this pull request, sorry... I revert the commit.

Edit -
Okay... learned something new today. Git automatically updates the pull request when I change the fork. makes sense, I just didn't knew that.
Did I revert the commit correctly?

@obendev
Copy link
Contributor Author

obendev commented Jun 15, 2019

You know what I'm doing a new pull request.

@obendev obendev closed this Jun 15, 2019
mattab pushed a commit that referenced this pull request Jun 18, 2019
* update all icons in info page footer

Thanks to @obendev for the idea in #14528

* update template
tsteur pushed a commit that referenced this pull request Jul 5, 2019
There are still old GitHub links in the footer of the 'About matomo'-Page
I changed them to the new ones, so that there is no unnecessary redirect
Old pull request #14528
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants