Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"URLs" Website Measurable Setting cannot be saved empty #14510

Open
MichaelRoosz opened this issue Jun 4, 2019 · 3 comments
Open

"URLs" Website Measurable Setting cannot be saved empty #14510

MichaelRoosz opened this issue Jun 4, 2019 · 3 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.

Comments

@MichaelRoosz
Copy link
Contributor

MichaelRoosz commented Jun 4, 2019

Given there is a website measurable with at least one url in the "URLs" setting.

Now if I try to remove this URL (save the setting empty). It will appear to work. but after reloading the config page, it is clear that the "URLs" setting has still the old value.

This makes it impossible to save "URL"s with an empty value, if it is non-empty.

The documentation does not say this is impossible, nor is an error thrown, so this should be a bug.

@tsteur
Copy link
Member

tsteur commented Jun 6, 2019

Does it work when you comment this exception? https://github.com/matomo-org/matomo/blob/3.10.0-b3/plugins/WebsiteMeasurable/Settings/Urls.php#L74

Not sure why we are checking for a URL, I think it is not needed anymore.

@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Jan 21, 2020
@mattab
Copy link
Member

mattab commented Jan 21, 2020

Hi @MichaelHeerklotz - thanks for the report. Are you maybe able to check the latest comment above?

@MichaelRoosz
Copy link
Contributor Author

I will test it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

4 participants