New Goal type: Convert when user stays more than X minutes on the site #14508

diosmosis · 2019-06-03T05:17:10Z

This PR adds the following types of goals:

goals based on visit duration

core/Tracker/GoalManager.php

tsteur · 2019-06-03T05:44:16Z

Is there an issue for this?

diosmosis · 2019-06-03T06:12:35Z

Is there an issue for this?

Not that I could find, though matt thought there was one, I noticed the discrepancy when working on the GA importer. There are goal types we won't be able to import. It didn't seem like a complicated change.

GA provides 'visit duration' goals + 'total number of pages viewed'. They also allow matching on multiple event attributes, but that seems like a more complicated addition.

core/Tracker/GoalManager.php

tsteur · 2019-06-07T11:02:46Z

plugins/Goals/API.php

    {
        if (empty($patternType)) {
            return '';
        }

        $patternType = strtolower($patternType);

-        $validator = new WhitelistedValue(['exact', 'contains', 'regex']);
+        if (in_array($matchAttribute, GoalManager::$NUMERIC_MATCH_ATTRIBUTES)) {
+            $validValues = ['>'];


not sure, should we maybe use greater_than or so?

I think we do this in some other places.

There's a limit on the field size, I think 'greater_than' was a little too long. Didn't want to create a db upgrade for something so small, but I can if it's better.

it's fine to have an update for it as it's not a log table.

tsteur · 2019-06-07T11:33:57Z

is it possible to not show "case insensitive" for numeric goals? And maybe ideally pattern would show "in seconds" or so. Because the example says minutes but I reckon the number we enter is in seconds?

tsteur · 2019-06-07T11:35:53Z

maybe the colon could go "in triggered when" column and it could say "greater than" as not everyone would understand >?

tsteur · 2019-06-07T11:41:27Z

Seems to work otherwise in general 👍 . Only now seeing we enter the visit duration in minutes, should it be seconds maybe? just to be a bit more flexible... although I don't think anyone would want to trigger a goal after a few seconds... so minutes should be fine.

mattab · 2019-06-30T22:30:31Z

Seems to work otherwise in general +1 . Only now seeing we enter the visit duration in minutes, should it be seconds maybe? just to be a bit more flexible... although I don't think anyone would want to trigger a goal after a few seconds... so minutes should be fine.

Minutes should be better I reckon, but maybe allow for less than 1 minutes, or in general decimal minutes (1.5, 5.5, etc) so it's flexible (didn't check if maybe this already works)

diosmosis · 2019-07-02T21:56:02Z

@mattab Updated so it would allow floating point values for minutes (test should reflect this).

@tsteur Applied review fixes

mattab · 2019-07-03T23:59:06Z

Feedback:

Change Pattern to Time in minutes
In inline help, explain the tip that one can specify time in seconds for example 30 seconds by writing 0.5 in the field.
Does Allow multiple conversions per visit make sense for this new goal type? reckon it does not and could be removed. (This type of Goal would only be converted once per visit always?)
In the Manage goals it says visit_duration \n Pattern greater_than: 5 -> can we change it to Visit duration greater than 5 minutes
UI tests need updates
The user guide https://matomo.org/docs/tracking-goals-web-analytics/ will need updated

Looking forward to merging this so we can start beta testing our Google Analytics importer 🚀 🚀

diosmosis · 2019-07-05T16:17:07Z

@mattab updated everything except screenshot test update

mattab · 2019-07-11T00:42:54Z

Looks great & works! 👍

@diosmosis Be great if you could also edit the user guide at https://matomo.org/docs/tracking-goals-web-analytics/ and mention this new goal type and feature.

(just added it now to: https://matomo.org/features)

diosmosis · 2019-07-11T20:22:09Z

@mattab

Be great if you could also edit the user guide at https://matomo.org/docs/tracking-goals-web-analytics/ and mention this new goal type and feature.

Updated.

diosmosis added 3 commits June 2, 2019 09:13

start adding new goal type

ac70c97

Add new goal type to UI + tracker + add tests.

d02bda8

Cache pageview count query result.

03fb792

diosmosis added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Needs Review PRs that need a code review labels Jun 3, 2019

diosmosis added this to the 3.11.0 milestone Jun 3, 2019

tsteur reviewed Jun 3, 2019

View reviewed changes

core/Tracker/GoalManager.php Outdated Show resolved Hide resolved

tsteur reviewed Jun 3, 2019

View reviewed changes

core/Tracker/GoalManager.php Outdated Show resolved Hide resolved

Apply pr feedback

fab00bf

diosmosis changed the title ~~New goal types to match goals in GA~~ New goal type to match one goal type in GA Jun 4, 2019

fdellwing reviewed Jun 4, 2019

View reviewed changes

core/Tracker/GoalManager.php Outdated Show resolved Hide resolved

diosmosis added 2 commits June 4, 2019 14:15

remove debugging code

1808a19

remove unused code

55221b1

tsteur reviewed Jun 7, 2019

View reviewed changes

Merge branch '3.x-dev' into ga-goal-types

d783b41

diosmosis added 4 commits July 2, 2019 13:09

Merge branch '3.x-dev' into ga-goal-types

8cc4e98

Merge branch '3.x-dev' into ga-goal-types

7f2d46d

Apply review feedback.

77b4151

fix test

3714291

mattab assigned diosmosis Jul 4, 2019

mattab self-requested a review July 4, 2019 00:02

Apply review comments.

fc63a0e

diosmosis merged commit f0c53c4 into 3.x-dev Jul 11, 2019

diosmosis deleted the ga-goal-types branch July 11, 2019 20:33

mattab changed the title ~~New goal type to match one goal type in GA~~ New Goal type: Convert when user stays more than X minutes on the site Jul 23, 2019

mattab added the Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. label Jul 23, 2019

mattab mentioned this pull request Oct 21, 2019

Tracking Goal: define a goal as 'viewed more than N pages' (requires a new visit_total_pageviews column in the table) #2029

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Goal type: Convert when user stays more than X minutes on the site #14508

New Goal type: Convert when user stays more than X minutes on the site #14508

diosmosis commented Jun 3, 2019 •

edited

tsteur commented Jun 3, 2019

diosmosis commented Jun 3, 2019

tsteur Jun 7, 2019

tsteur Jun 7, 2019

diosmosis Jun 7, 2019

tsteur Jul 1, 2019

tsteur commented Jun 7, 2019

tsteur commented Jun 7, 2019

tsteur commented Jun 7, 2019

mattab commented Jun 30, 2019

diosmosis commented Jul 2, 2019

mattab commented Jul 3, 2019 •

edited

diosmosis commented Jul 5, 2019

mattab commented Jul 11, 2019

diosmosis commented Jul 11, 2019

New Goal type: Convert when user stays more than X minutes on the site #14508

New Goal type: Convert when user stays more than X minutes on the site #14508

Conversation

diosmosis commented Jun 3, 2019 • edited

tsteur commented Jun 3, 2019

diosmosis commented Jun 3, 2019

tsteur Jun 7, 2019

Choose a reason for hiding this comment

tsteur Jun 7, 2019

Choose a reason for hiding this comment

diosmosis Jun 7, 2019

Choose a reason for hiding this comment

tsteur Jul 1, 2019

Choose a reason for hiding this comment

tsteur commented Jun 7, 2019

tsteur commented Jun 7, 2019

tsteur commented Jun 7, 2019

mattab commented Jun 30, 2019

diosmosis commented Jul 2, 2019

mattab commented Jul 3, 2019 • edited

diosmosis commented Jul 5, 2019

mattab commented Jul 11, 2019

diosmosis commented Jul 11, 2019

diosmosis commented Jun 3, 2019 •

edited

mattab commented Jul 3, 2019 •

edited