@diosmosis opened this Pull Request on June 3rd 2019 Member

This PR adds the following types of goals:

  • goals based on visit duration
@tsteur commented on June 3rd 2019 Member

Is there an issue for this?

@diosmosis commented on June 3rd 2019 Member

Is there an issue for this?

Not that I could find, though matt thought there was one, I noticed the discrepancy when working on the GA importer. There are goal types we won't be able to import. It didn't seem like a complicated change.

GA provides 'visit duration' goals + 'total number of pages viewed'. They also allow matching on multiple event attributes, but that seems like a more complicated addition.

@tsteur commented on June 7th 2019 Member

image

is it possible to not show "case insensitive" for numeric goals? And maybe ideally pattern would show "in seconds" or so. Because the example says minutes but I reckon the number we enter is in seconds?

@tsteur commented on June 7th 2019 Member

image

maybe the colon could go "in triggered when" column and it could say "greater than" as not everyone would understand >?

@tsteur commented on June 7th 2019 Member

Seems to work otherwise in general :+1: . Only now seeing we enter the visit duration in minutes, should it be seconds maybe? just to be a bit more flexible... although I don't think anyone would want to trigger a goal after a few seconds... so minutes should be fine.

@mattab commented on June 30th 2019 Member

Seems to work otherwise in general +1 . Only now seeing we enter the visit duration in minutes, should it be seconds maybe? just to be a bit more flexible... although I don't think anyone would want to trigger a goal after a few seconds... so minutes should be fine.

Minutes should be better I reckon, but maybe allow for less than 1 minutes, or in general decimal minutes (1.5, 5.5, etc) so it's flexible (didn't check if maybe this already works)

@diosmosis commented on July 2nd 2019 Member

@mattab Updated so it would allow floating point values for minutes (test should reflect this).

@tsteur Applied review fixes

@mattab commented on July 3rd 2019 Member

Feedback:

  • Change Pattern to Time in minutes
  • In inline help, explain the tip that one can specify time in seconds for example 30 seconds by writing 0.5 in the field.
  • Does Allow multiple conversions per visit make sense for this new goal type? reckon it does not and could be removed. (This type of Goal would only be converted once per visit always?)
  • In the Manage goals it says visit_duration \n Pattern greater_than: 5 -> can we change it to Visit duration greater than 5 minutes
  • UI tests need updates
  • The user guide https://matomo.org/docs/tracking-goals-web-analytics/ will need updated

Looking forward to merging this so we can start beta testing our Google Analytics importer :rocket: :rocket:

@diosmosis commented on July 5th 2019 Member

@mattab updated everything except screenshot test update

@mattab commented on July 11th 2019 Member

Looks great & works! :+1:

@diosmosis Be great if you could also edit the user guide at https://matomo.org/docs/tracking-goals-web-analytics/ and mention this new goal type and feature.

(just added it now to: https://matomo.org/features)

@diosmosis commented on July 11th 2019 Member

@mattab

Be great if you could also edit the user guide at https://matomo.org/docs/tracking-goals-web-analytics/ and mention this new goal type and feature.

Updated.

This Pull Request was closed on July 11th 2019
Powered by GitHub Issue Mirror