@diosmosis opened this Pull Request on June 3rd 2019 Member

This PR adds the following types of goals:

  • goals based on visit duration
@tsteur commented on June 3rd 2019 Member

Is there an issue for this?

@diosmosis commented on June 3rd 2019 Member

Is there an issue for this?

Not that I could find, though matt thought there was one, I noticed the discrepancy when working on the GA importer. There are goal types we won't be able to import. It didn't seem like a complicated change.

GA provides 'visit duration' goals + 'total number of pages viewed'. They also allow matching on multiple event attributes, but that seems like a more complicated addition.

@tsteur commented on June 7th 2019 Member

image

is it possible to not show "case insensitive" for numeric goals? And maybe ideally pattern would show "in seconds" or so. Because the example says minutes but I reckon the number we enter is in seconds?

@tsteur commented on June 7th 2019 Member

image

maybe the colon could go "in triggered when" column and it could say "greater than" as not everyone would understand >?

@tsteur commented on June 7th 2019 Member

Seems to work otherwise in general :+1: . Only now seeing we enter the visit duration in minutes, should it be seconds maybe? just to be a bit more flexible... although I don't think anyone would want to trigger a goal after a few seconds... so minutes should be fine.

Powered by GitHub Issue Mirror