Ensure incompatible visualization entries are still shown as footer icons when they are selected #14507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
c: Design / UI
tsteur
reviewed
Jun 3, 2019
…hen they are still selected
tsteur
approved these changes
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When viewing for example a insights report for a unsupported date/period combination, the report currently won't show any visualization icons to switch to another one.
That is caused by the fact that the currently enabled visualization isn't available (
canDisplayViewDataTablereturnsfalse). With the current visualization absent the view won't show any visualization icons (caused by https://github.com/matomo-org/matomo/blob/3.x-dev/plugins/CoreHome/templates/_dataTableActions.twig#L9-L34 and https://github.com/matomo-org/matomo/blob/3.x-dev/plugins/CoreHome/templates/_dataTableActions.twig#L54)Imho it's makes most sense to add the current visualization to the icons even if wouldn't be present anymore. That way it will be shown as active, and it's possible again to switch to another one.
fixes #14071