Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core:purge-old-archive-data command: remove --force-optimize-tables option and always optimise tables #14498

Closed
mattab opened this issue May 29, 2019 · 2 comments · Fixed by #14895
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@mattab
Copy link
Member

mattab commented May 29, 2019

Customer reported bug that running the command ./console core:purge-old-archive-data all didn't save DB space. They also had to run ./console database:optimize-archive-tables all afterwards.

Suggested steps:

  • In the core:purge-old-archive-data console command, let's remove --force-optimize-tables option and always optimise tables
  • in Db::optimizeTables let's remove the second parameter $force = false and always force optimise tables (the code already checks isOptimizeInnoDBSupported which should be enough) (not wanted actually)
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label May 29, 2019
@mattab mattab added this to the 3.12.0 milestone May 29, 2019
@tsteur
Copy link
Member

tsteur commented May 29, 2019

On Cloud we don't want to run always optimize. So this would need to be again a setting to disable this behaviour.

@mattab
Copy link
Member Author

mattab commented Jun 12, 2019

Ok, removed the second bullet point, but first one still valid (as per discussion)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants