Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to current ip in UserCountry.getLocationFromIp and add some tests. #14497

Merged
merged 1 commit into from May 29, 2019
Merged

Default to current ip in UserCountry.getLocationFromIp and add some tests. #14497

merged 1 commit into from May 29, 2019

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented May 29, 2019 •
edited

Fixes #14496

@diosmosis diosmosis added the Needs Review PRs that need a code review label May 29, 2019
@diosmosis diosmosis added this to the 3.10.0 milestone May 29, 2019
@mattab mattab merged commit f8316ae into 3.x-dev May 29, 2019
@mattab
Copy link
Member

mattab commented May 29, 2019

Looks good @diosmosis 👍

@mattab mattab deleted the ip-default branch May 29, 2019 03:54
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.

API to return current user's geolocation "UserCountry.getLocationFromIP"
2 participants
@diosmosis @mattab