New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cookie warning pops up in IE11 ShowModalDialog #14495
Conversation
…ugfix11507 11507 - Cookie warning pops up in IE11 ShowModalDialog
Reviewer, also quick note on the piwik.js file being modified. It was assumed that the minified version of the file would be generated as part of build process, and hence explicitly not modified. Please let me know if anything else needs to be done along with this JS file. |
The change looks ok to me, if we can set a cookie properly, that should be enough. To be safe though, we could surround the test in a try-catch. What do you think @tsteur ? |
Sounds good @diosmosis |
Yes, makes sense, if something bad happens when we try and set a cookie, we can't set a cookie. |
Thanks @diosmosis and @tsteur for your feedback. Is there any action item from my side or will you be able to help merge this change? |
There is nothing that needs to be done. We will include this in the 3.11 release. There's not enough testing time for 3.10 release unfotunately. |
FYI: I always got "Access denied" when using In general I was worried removing Couldn't find a blame why this check was added initially to see if it causes any problem maybe c654e73#diff-1279d666063b65e6d6777f902d11574f @mattab not sure if there could be any regression or problem with it but suppose it should be fine. At the same time popups are blocked by default in IE and not sure where this method Assuming all browsers hopefully behave the same it should be fine to merge. |
Not sure if you're still having problems reproducing or not, but the file below should help. You can open it in IE11 straight from your desktop, just hit "Allow Blocked Content" at the bottom if you get prompted. |
To re-iterate, this is an important fix that is causing lot of problems with the manual code modifications to piwik.js file and yet times it is getting overwritten and resulting in production critical issues. Thanks for your help and understanding. Please let us know if you can merge this for 3.12. |
@tsteur Reckon we can just merge it. In the worst case it would regress the accuracy of tracking how many users support Cookies. I'll set a reminder to check the reports in 2 months. |
Sweet, this PR is good to merge. We just need to update the minified tracker version afterwards. |
Just merged, thanks @siva538 for the great first contribution! |
Issue with ShowModalDialog in IE browser is fixed.
fixes #11507