Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If new visit is forced, known visitors should still be recognized #14491

Merged
merged 7 commits into from Jul 12, 2019
Merged

If new visit is forced, known visitors should still be recognized #14491

merged 7 commits into from Jul 12, 2019

Conversation

diosmosis
Copy link
Member

Fixes #14452

@diosmosis diosmosis added the Needs Review PRs that need a code review label May 27, 2019
@diosmosis diosmosis added this to the 3.10.0 milestone May 27, 2019
@diosmosis diosmosis mentioned this pull request May 27, 2019
Closed
@mattab mattab modified the milestones: 3.10.0, 3.11.0 May 28, 2019
sgiehl
sgiehl approved these changes Jul 11, 2019
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a rough look through the changes. Looks all good to me.
@diosmosis conflicts with submodule needs to be resolved before merge...

@diosmosis diosmosis merged commit 2eaa403 into 3.x-dev Jul 12, 2019
@diosmosis diosmosis deleted the is-visit-new branch July 12, 2019 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
3.11.0
Development

Successfully merging this pull request may close these issues.

Why the visitor_days_since_first is not gradually increasing
3 participants
@diosmosis @sgiehl @mattab