Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Couple changes to visitor log for proxysite #14481

Merged
merged 2 commits into from May 28, 2019
Merged

Couple changes to visitor log for proxysite #14481

merged 2 commits into from May 28, 2019

Conversation

diosmosis
Copy link
Member

Three fixes:

  • CustomDimensions must use API in one instance.
  • If product categories not present, don't display.
  • idSite query parameter is not present in visitor details when proxysite is used, since VisitorDetailsAbstract::setDetails() is only called in the API. So when the visitor log visualization tries to use it through the Live event, the idSite is absent and an error occurs.

@diosmosis diosmosis added the Needs Review PRs that need a code review label May 24, 2019
@diosmosis diosmosis added this to the 3.10.0 milestone May 24, 2019
@mattab mattab merged commit e35fcd8 into 3.x-dev May 28, 2019
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jun 29, 2019
@mattab mattab deleted the visitor-log-proxy branch June 29, 2019 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @mattab