@Findus23 opened this Pull Request on May 24th 2019 Member

fixes #14475

I think using PHP builtins instead of a 10 year old library avoids bugs and having to maintain a frequently changing list of all valid TLDs.

And the only email validation that is really correct is sending an actual email as suggested in https://github.com/matomo-org/matomo/issues/13533

@tsteur commented on July 5th 2019 Member

Looks good to merge. There are a few comments re this filter and that it maybe behave a bit more strict or so but the comments are old and I reckon it's fine 👍 https://www.php.net/manual/en/filter.filters.validate.php

Before merging though could you remove the code from here @Findus23 https://github.com/matomo-org/matomo/blob/3.10.0/config/global.php#L203-L209

and I reckon we could also remove the zend class itself? It doesn't seem to be used

@Findus23 commented on July 13th 2019 Member

@tsteur Should be done in https://github.com/matomo-org/matomo/pull/14476/commits/c9b59938461513bb67a0d3fa42aa30c89f7b8a2d

I guess one day we should be removing all of those zend classes and replace them with modern libraries.

This Pull Request was closed on July 14th 2019
Powered by GitHub Issue Mirror