use PHP filter to validate E-Mails #14476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to merge. There are a few comments re this filter and that it maybe behave a bit more strict or so but the comments are old and I reckon it's fine 👍 https://www.php.net/manual/en/filter.filters.validate.php Before merging though could you remove the code from here @Findus23 https://github.com/matomo-org/matomo/blob/3.10.0/config/global.php#L203-L209 and I reckon we could also remove the zend class itself? It doesn't seem to be used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14475
I think using PHP builtins instead of a 10 year old library avoids bugs and having to maintain a frequently changing list of all valid TLDs.
And the only email validation that is really correct is sending an actual email as suggested in #13533