Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply the search term to the Show total rows count #14473

Open
NanorPiwik opened this issue May 23, 2019 · 3 comments
Open

Apply the search term to the Show total rows count #14473

NanorPiwik opened this issue May 23, 2019 · 3 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently.

Comments

@NanorPiwik
Copy link

When we enter a search term for the page url report the show total rows count apply to the full report and does not include only the search we performed.

@mattab mattab added the c: Usability For issues that let users achieve a defined goal more effectively or efficiently. label Jan 21, 2020
@mattab mattab added this to the Backlog (Help wanted) milestone Jan 21, 2020
@9joshua
Copy link
Contributor

9joshua commented Aug 23, 2023

Another request for the same.

Example:
image

@michalkleiner michalkleiner added the Bug For errors / faults / flaws / inconsistencies etc. label Sep 27, 2023
@michalkleiner
Copy link
Contributor

Marking this as a bug since the search-based filtering of the table isn't correctly applied to the totals row.

@sgiehl
Copy link
Member

sgiehl commented Sep 28, 2023

That is more likely an issue of the order the filters are applied. The totals row is afaik calculated quite early and the search filter is applied quite lately before it's displayed. Might not be an easy one to tackle that, as applying the search eariler might make problems when e.g. the labels are manipulated in the API methods and the search should be applied afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently.
Projects
None yet
Development

No branches or pull requests

5 participants