Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript declaration #14472

Closed
alexandrestein opened this issue May 23, 2019 · 4 comments
Closed

Add TypeScript declaration #14472

alexandrestein opened this issue May 23, 2019 · 4 comments
Labels
wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.

Comments

@alexandrestein
Copy link

I'm using VueJS with TypeScript.

TypeScript is great to develop complex application with much less risks of type error and some other common errors.
But when you try to use pure JS it become a nightmare (at least for me).

I'm sure some of the maintainer has much more JS and probably TS skills than I do.

Would it be possible to see the typescript declaration for the Piwik file.

@Findus23 Findus23 added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label May 23, 2019
@Findus23
Copy link
Member

Hi,

While I have used typescript before, I don't think I can maintain proper typings.
So if someone wants to help, they can create a typeset declaration and submit it to https://github.com/DefinitelyTyped/DefinitelyTyped

@tsteur
Copy link
Member

tsteur commented May 23, 2019

Hi @alexandrestein there are no plans to convert the JS tracker to typescript or any typeset declaration (as we would likely need to maintain it). We can currently manage the code without it and we want to avoid needing to convert the code re cross browser etc.

@alexandrestein
Copy link
Author

Well, worth to try. 😄
Thank you for your quick answers.

@tsteur
Copy link
Member

tsteur commented May 24, 2019

Thanks for the suggestion though. We might consider it at a later stage but not anytime soon.

@tsteur tsteur closed this as completed May 24, 2019
@tsteur tsteur added answered For when a question was asked and we referred to forum or answered it. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it. and removed Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. answered For when a question was asked and we referred to forum or answered it. labels May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Development

No branches or pull requests

3 participants