Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New command to send test emails #14467

Merged
merged 3 commits into from May 24, 2019
Merged

New command to send test emails #14467

merged 3 commits into from May 24, 2019

Conversation

katebutler
Copy link

Fixes #14302

@mattab mattab added this to the 3.10.0 milestone May 21, 2019
@mattab mattab added the Needs Review PRs that need a code review label May 21, 2019
@diosmosis
Copy link
Member

The suggested message/subject described in #14455 (linked in #14302) is a bit different than what's in this PR, can that be changed? Also it mentions sending an HTML email so Maill::setWrappedHtmlBody() would need to be used.

@katebutler
Copy link
Author

Thanks @diosmosis, have updated with the content suggested on #14455

diosmosis
diosmosis approved these changes May 23, 2019
View reviewed changes
Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works. Not sure if @mattab had any ideas regarding extra debug information, otherwise this can be merged.

Findus23
Findus23 approved these changes May 23, 2019
View reviewed changes
Copy link
Member

@Findus23 Findus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.
I hope this helps debugging mail issues in the future.

@mattab
Copy link
Member

mattab commented May 24, 2019

Would be great to have more debug information but I don't know how that's possible. Merging for now 👍

@mattab mattab merged commit b9df06d into 3.x-dev May 24, 2019
@mattab mattab deleted the 14302 branch June 29, 2019 11:10
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jun 29, 2019
@mattab
Copy link
Member

mattab commented Jun 29, 2019

fyi Documented in: Emails from Matomo are not being sent, how do I troubleshoot and solve the issue?

@mattab mattab added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Jun 29, 2019
@Findus23 Findus23 mentioned this pull request Oct 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis diosmosis approved these changes

@Findus23 Findus23 Findus23 approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.

New cli command to send test-mail to admin
4 participants
@katebutler @diosmosis @mattab @Findus23