@katebutler opened this Pull Request on May 20th 2019 Member

Fixes #14118

@katebutler commented on June 19th 2019 Member

Ready for review/merge

@tsteur commented on July 5th 2019 Member

In the personal settings page, should we mention this block maybe very first?

and I suppose we need to maybe show a privacy notice, similar to on our website https://matomo.org/newsletter :

@tsteur commented on July 5th 2019 Member

fyi @katebutler see previous comment

@tsteur commented on July 5th 2019 Member

Actually, I reckon by the time we show the privacy notice it'll take too much space.

Also to be safe re GDPR it might be good to show an unchecked checkbox and the button be disabled initially (disabled=true|false attribute should do this in angular). Clicking on the checkbox would enable the Yes button. Not sure if checkbox is needed though @Findus23 any thoughts?

@katebutler commented on July 22nd 2019 Member

Have added a short privacy notice and a checkbox.

@tsteur commented on July 29th 2019 Member

BTW there's also a merge conflict

@tsteur commented on August 5th 2019 Member
@tsteur commented on August 7th 2019 Member

@katebutler there's still a failing test BTW: https://builds-artifacts.matomo.org/matomo-org/matomo/3.x-dev/35326/UserSettings_signup_success.png

The expected message is no longer showing as the success message is now shown in a success notification. We can usually take a screnshot of that using #notificationcontainer or something similar (don't remember the ID of the notifications container).

This Pull Request was closed on August 13th 2019
Powered by GitHub Issue Mirror