Using query params here allows us to send query params over in ProxySite, so the processed metrics are computed properly and displayed properly.
some tests are failing, eg this one: https://builds-artifacts.matomo.org/matomo-org/matomo/3.x-dev/34312/GoalsTable_goals_table_ecommerce.png
@diosmosis Can you check the failing tests and adjust PR so we can hopefully merge? Or shall we maybe move it to 3.11.0 if you need more time?
Waiting for tests to finish before calling it done, but the issue mentioned is fixed
I didn't test it but looks good to me to merge if tests pass. Not quite sure how to reproduce it etc so hard to tell.
Just to explain, bug here is that
AddColumnsProcessedMetricsGoal uses processed metrics and is used directly in the goals table visualization. When proxying requests, the target instance computes processed metrics, so to avoid errors we don't do it again in the proxy instance. This means the processed metrics added by the filter are not computed. Using a query param here allows us to compute the metrics in the target instance.