@diosmosis opened this Pull Request on May 20th 2019 Member

Using query params here allows us to send query params over in ProxySite, so the processed metrics are computed properly and displayed properly.

@tsteur commented on June 7th 2019 Member
@mattab commented on June 10th 2019 Member

@diosmosis Can you check the failing tests and adjust PR so we can hopefully merge? Or shall we maybe move it to 3.11.0 if you need more time?

@mattab commented on June 11th 2019 Member

@diosmosis is this done?
@tsteur could you please review & merge if it looks good to you?

@diosmosis commented on June 11th 2019 Member

Waiting for tests to finish before calling it done, but the issue mentioned is fixed

@tsteur commented on June 11th 2019 Member

I didn't test it but looks good to me to merge if tests pass. Not quite sure how to reproduce it etc so hard to tell.

@diosmosis commented on June 12th 2019 Member

Just to explain, bug here is that AddColumnsProcessedMetricsGoal uses processed metrics and is used directly in the goals table visualization. When proxying requests, the target instance computes processed metrics, so to avoid errors we don't do it again in the proxy instance. This means the processed metrics added by the filter are not computed. Using a query param here allows us to compute the metrics in the target instance.

This Pull Request was closed on June 12th 2019
Powered by GitHub Issue Mirror