Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cities do not correspond to regions #14462

Closed
h3t1 opened this issue May 19, 2019 · 5 comments · Fixed by #14712
Closed

Cities do not correspond to regions #14462

h3t1 opened this issue May 19, 2019 · 5 comments · Fixed by #14712
Assignees
@sgiehl

Comments

@h3t1
Copy link

h3t1 commented May 19, 2019

Hi, I'm using matomo 3.9.1 with GeoIP 2 (PHP)
The problem is that Moroccan cities are not matching regions (also the map is showing incorrect regions for cities) as you can see in the picture below :
map
I also tested some IP address here:
https://www.maxmind.com/en/geoip-demo
and seems like everything is OK, so I do not know where the problem comes from.
PS: I can help correct Moroccan cities to match their regions
@sgiehl
Copy link
Member

sgiehl commented Jul 29, 2019

Hi there. Sorry for the delay. What exactly is wrong with the regions? We actually only use the data provided by Maxmind in this case. Only the region names are stored within in Matomo, but I don't think the mapping from ISO codes to region names has changed. See https://github.com/matomo-org/matomo/blob/3.x-dev/plugins/GeoIp2/data/isoRegionNames.php#L2979-L3060

@h3t1
Copy link
Author

h3t1 commented Jul 29, 2019

Hi! Thank you for your reply,
I think the ISO mapping may have changed because Morocco has recently changed its regions from 16 to 12 regions.
image
image
source : https://en.wikipedia.org/wiki/Regions_of_Morocco

@h3t1
Copy link
Author

h3t1 commented Jul 29, 2019

here is a demo that shows the difference between Maxmind and Matomo for the same address ip:
IP address: 41.249.92.68
rabat
Untitled1

@sgiehl
Copy link
Member

sgiehl commented Jul 29, 2019

ah ok. so we need to update our region mapping. Will have a look at that

@sgiehl sgiehl self-assigned this Jul 29, 2019
@sgiehl sgiehl mentioned this issue Jul 30, 2019
Merged
@r3tr0sp3c
Copy link

Also for greek city / region combinations

screenshot

Larisa and Volos belong to Thessaly, in the mainlands , not Zakynthos which is an island.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds command to update iso region names matomo-org/matomo
3 participants
@sgiehl @h3t1 @r3tr0sp3c