Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segment menu behind overlay of transition #14459

Merged
merged 1 commit into from Jun 18, 2019

Conversation

fdellwing
Copy link
Contributor

Fixes #14458

Someone not really knowing how z-index works seems to have done an oopsie here ;)

@fdellwing
Copy link
Contributor Author

Additional note: This was also broken if you added the report as widget to the dashboard. That is fixed with this PR as well.

@Findus23 Findus23 added the Needs Review PRs that need a code review label May 17, 2019
@fdellwing
Copy link
Contributor Author

I think it would be good to have a test to make sure this does not regress, but I have no clue about writing these.

@mattab mattab added this to the 3.11.0 milestone Jun 10, 2019
Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

No need for a new test, UI tests take a long time to run so we don't want to add new ones for small issues like this. Otherwise the run time can really add up.

@mattab mattab merged commit 0d5378e into matomo-org:3.x-dev Jun 18, 2019
@fdellwing fdellwing deleted the z_index_transitions_report branch June 19, 2019 06:38
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segment menu behind overlay of transition
4 participants