Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update video content on Welcome widget #14454

Merged
merged 6 commits into from May 28, 2019
Merged

Update video content on Welcome widget #14454

merged 6 commits into from May 28, 2019

Conversation

katebutler
Copy link

@katebutler katebutler commented May 16, 2019

fixes #13740

@katebutler katebutler added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label May 16, 2019
@katebutler katebutler added this to the 3.11.0 milestone May 16, 2019
Copy link
Member

@Findus23 Findus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, just a quick info: You have made the tmp/.gitkeep and tmp/CACHEDIR.TAG 755 instead of 644.

@katebutler katebutler added Needs Review PRs that need a code review and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels May 20, 2019
@katebutler
Copy link
Author

Thanks @Findus23, have fixed those

@mattab mattab merged commit d100ab0 into 3.x-dev May 28, 2019
@mattab mattab deleted the 13740 branch May 28, 2019 01:28
@mattab mattab modified the milestones: 3.11.0, 3.10.0 May 28, 2019
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Promo video with new Matomo videos
3 participants