Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix download issues via cURL with HTTP/2 #14449

Merged
merged 1 commit into from Jul 16, 2019
Merged

Fix download issues via cURL with HTTP/2 #14449

merged 1 commit into from Jul 16, 2019

Conversation

katebutler
Copy link

@katebutler katebutler commented May 15, 2019

Fix two issues observed when downloading the GeoIP database via cURL with HTTP/2:

  • The response headers are returned in lowercase e.g. 'content-length' instead of 'Content-Length'
  • Work around an apparent bug in libcurl where sending a Range header via CURLOPT_HTTPHEADER causes curl to error "Failed sending HTTP request". Sending it via CURLOPT_RANGE instead has been tested with HTTP/1.1 and HTTP/2 and works with both.

Fixes #14339

@katebutler katebutler added the Needs Review PRs that need a code review label May 15, 2019
@katebutler katebutler added this to the 3.12.0 milestone May 15, 2019
@Findus23
Copy link
Member

Perfect, this fixes it for me!
There might be more HTTP/2 bugs in Matomo, but at least this download now works fine.

@mattab mattab modified the milestones: 3.12.0, 3.10.0, 3.11.0 Jun 16, 2019
Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP header are not case insensitive
5 participants