Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow to disable tracking failure notifications #14448

Merged
merged 2 commits into from Jul 8, 2019
Merged

allow to disable tracking failure notifications #14448

merged 2 commits into from Jul 8, 2019

Conversation

fdellwing
Copy link
Contributor

Fixes #14447 in a very basic way.

@mattab mattab added this to the 3.11.0 milestone Jun 10, 2019
@mattab mattab added the Needs Review PRs that need a code review label Jun 10, 2019
diosmosis
diosmosis approved these changes Jun 16, 2019
View reviewed changes
Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. @mattab what do you think about the new INI option?

@tsteur
Copy link
Member

tsteur commented Jun 17, 2019

@fdellwing @diosmosis usually these settings start with enable_

@diosmosis
Copy link
Member

👍 to prefix w/ enable_ for consistency

@fdellwing
Copy link
Contributor Author

Updated the PR :)

@diosmosis diosmosis merged commit b4e628a into matomo-org:3.x-dev Jul 8, 2019
@fdellwing fdellwing deleted the disable_tracking_failure_mail branch July 8, 2019 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis diosmosis approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
3.11.0
Development

Successfully merging this pull request may close these issues.

Feature request: option to disable tracking failure notifications
4 participants
@fdellwing @tsteur @diosmosis @mattab