Group different writings of Instagram in reports #14436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
not-in-changelog
tsteur
reviewed
May 9, 2019
plugins/Referrers/API.php
Outdated
| @@ -365,6 +365,13 @@ public function getSocials($idSite, $period, $date, $segment = false, $expanded | |||
|
|
|||
| $dataTable = Archive::createDataTableFromArchive(Archiver::SOCIAL_NETWORKS_RECORD_NAME, $idSite, $period, $date, $segment, $expanded, $flat); | |||
|
|
|||
| $dataTable->filter('GroupBy', ['label', function($value) { | |||
There was a problem hiding this comment.
Could we do this only if one or the other label exists? Typically the GroupBy filter is quite slow, and checking if a label exists in the report is really fast usually.
Not too important but could be worth thinking about it.
tsteur
reviewed
May 12, 2019
plugins/Referrers/API.php
Outdated
| @@ -365,6 +365,35 @@ public function getSocials($idSite, $period, $date, $segment = false, $expanded | |||
|
|
|||
| $dataTable = Archive::createDataTableFromArchive(Archiver::SOCIAL_NETWORKS_RECORD_NAME, $idSite, $period, $date, $segment, $expanded, $flat); | |||
|
|
|||
| $groupIntagramLabel = function($dataTable) use (&$groupIntagramLabel) { | |||
There was a problem hiding this comment.
@sgiehl might be better to create a filter for this? would remove some complexity and be better to read etc. like $dataTable->filter('Piwik\Plugins\Referrers\DataTable\Filter\Group') then you don't need to check if it's a map etc and in theory it would be even possible to write a unit test for the group filter but wouldn't really be needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14433