bower.json is aligned with librabies from libs/bower_components #14429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we're actually in the process of moving to NPM. Not sure if it is worth updating libs here in the meantime @diosmosis ? #14082 Would also need to check later if still all the ui tests work |
|
@tsteur probably not, I don't think it will confer any benefits to change bower.json now. But it would be good to double check we're using the right versions in the npm branch, so maybe don't close this PR. |
|
@diosmosis closing this PR for now and as part of #14082 we can then make sure the right versions are used. Otherwise we just keep looking at the PR. @mpashkovskiy cheers for the PR 👍 Sorry we can't merge it's simply due to the fact that we will be using npm in the future. |
|
Frankly speaking I can't wait when Matomo migrate to npm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that: