@mpashkovskiy opened this Pull Request on May 8th 2019

I noticed that:

  • versions of libraries in bower.json is out of sync with actual ones used from libs/bower_components
  • some of the libraries are missing in bower.json
@tsteur commented on May 8th 2019 Member

we're actually in the process of moving to NPM. Not sure if it is worth updating libs here in the meantime @diosmosis ? https://github.com/matomo-org/matomo/pull/14082

Would also need to check later if still all the ui tests work

@diosmosis commented on May 8th 2019 Member

@tsteur probably not, I don't think it will confer any benefits to change bower.json now. But it would be good to double check we're using the right versions in the npm branch, so maybe don't close this PR.

@tsteur commented on July 16th 2019 Member

@diosmosis closing this PR for now and as part of #14082 we can then make sure the right versions are used. Otherwise we just keep looking at the PR.

@mpashkovskiy cheers for the PR 👍 Sorry we can't merge it's simply due to the fact that we will be using npm in the future.

@mpashkovskiy commented on July 17th 2019

Frankly speaking I can't wait when Matomo migrate to npm!

This Pull Request was closed on July 16th 2019
Powered by GitHub Issue Mirror