Display error message after encountering ajax error in popover #14424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katebutler
added
the
not-in-changelog
diosmosis
reviewed
Jun 25, 2019
diosmosis
reviewed
Jun 25, 2019
|
I'm actually unable to trigger an error to test this with now. The original issue used the example of loading the row evolution popup, but errors in this (and others that I tried, like visitor details popup etc) seem to be handled by |
…r to be needed any more
|
Exceptions are now handled elsewhere (can't find where!) so this PR now only covers fatal errors. |
diosmosis
approved these changes
Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13951