Fix possible error in charts "[] operator not supported for strings" #14419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattab
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading the evolution chart for acquisition report, I received the following error
[] operator not supported for strings in /var/www/matomo/plugins/CoreVisualizations/Visualizations/Graph.php line 138That seems to happen as the default value for that variable used to be a
string. Using an empty array instead fixes the issue. Not sure which circumstances lead to that error, as I'm not able to reproduce it on demo. Might also be a regression of #14332 ?Actually I'm not sure why the default is
selectable_rows, as I couldn't find any usage of that string anywhere else.