@Valair opened this Pull Request on May 6th 2019

Force website IDs existence check even for super-admin.
Resolve https://github.com/matomo-org/matomo/issues/8697

@tsteur commented on May 6th 2019 Member

@Valair thanks for this 👍
As I thought a LOT of tests are now failing see eg https://travis-ci.org/matomo-org/matomo/jobs/528746645
https://travis-ci.org/matomo-org/matomo/jobs/528746646 and https://travis-ci.org/matomo-org/matomo/jobs/528746647

In our test fixtures a lot of tests will need to be corrected.

I see it complains eg that in an AnnotationTest the user doesn't have view access to idSite 2. Looking at https://github.com/matomo-org/matomo/blob/3.10.0-b1/tests/PHPUnit/Fixtures/TwoSitesWithAnnotations.php#L27 the two websites seem actually created. So not sure if the tests needs adjusting or if there are more things to change in the Access class itself.

Fixing all those tests can take quite a long time and possibly also some debugging etc. Please let us know if you're keen looking into it or not.

@Valair commented on May 7th 2019

Ok, I will try to setup e dev/test environment to look into those failed tests.

@mattab commented on June 10th 2019 Member

Hi @Valair Thank you for the PR! Do you think you will be able to setup the test environment to adjust tests? Be awesome if you can. We'd like to merge the PR :+1:

@Valair commented on June 11th 2019

Hi @mattab, I've setup a test environment and I'm slowly working on fixing tests

@tsteur commented on November 25th 2019 Member

@Valair closing this PR for now. Let me know if you're planning to work on it again and I can reopen. Cheers

This Pull Request was closed on November 25th 2019
Powered by GitHub Issue Mirror