Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace internal API requests with processed ones #14416

Merged
merged 3 commits into from May 17, 2019
Merged

Replace internal API requests with processed ones #14416

merged 3 commits into from May 17, 2019

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented May 6, 2019

In order to only manipulate the subtables of e.g. Referrers.getAll report it's required to process them and not call the API directly.

refs DEV-1603

@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label May 6, 2019
@sgiehl sgiehl added this to the 3.10.0 milestone May 6, 2019
@sgiehl sgiehl marked this pull request as ready for review May 6, 2019 13:06
@sgiehl sgiehl added the Needs Review PRs that need a code review label May 6, 2019
tsteur
tsteur reviewed May 6, 2019
View reviewed changes
plugins/Referrers/API.php Outdated Show resolved Hide resolved
@tsteur
Copy link
Member

tsteur commented May 8, 2019

Looks good if tests pass

@diosmosis diosmosis merged commit 60a33e2 into 3.x-dev May 17, 2019
@diosmosis diosmosis deleted the apireplace branch May 17, 2019 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur left review comments

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sgiehl @tsteur @diosmosis