Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Metric instances to be stored in Report::$metrics. #14414

Merged
merged 2 commits into from May 13, 2019
Merged

Allow Metric instances to be stored in Report::$metrics. #14414

merged 2 commits into from May 13, 2019

Conversation

diosmosis
Copy link
Member

No description provided.

@diosmosis diosmosis added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels May 6, 2019
@diosmosis diosmosis added this to the 3.10.0 milestone May 6, 2019
@tsteur
Copy link
Member

tsteur commented May 6, 2019

I reckon should be fine if tests pass 👍 (didn't test, only looked at code)

@diosmosis diosmosis merged commit 1b2ee7f into 3.x-dev May 13, 2019
@diosmosis diosmosis deleted the metrics-documentation-tweak branch May 13, 2019 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @tsteur