Don't tell people to run chmod -R 755 on their install if update fails #14412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix #13628 For not writable directory it generated eg this: ``` chown -R foo:localaccounts /var/www/matomo find /var/www/matomo/tmp -type f -exec chmod 644 {} \; find /var/www/matomo/tmp -type d -exec chmod 755 {} \; ``` for auto update it also adds execute permission for `console` ``` chmod 755 /var/www/matomo/console ``` Not sure if any other file needs permission to execute? Couldn't think of any right now. Of course the find commands above they don't change the permission of any symlinks or so. Not sure what users possibly have in there and if it could create some issue. Could extend the find command to something like `-type f or -type l`. Also generally not sure if `find` is compatible like this on all *nix. @Findus23 maybe any thoughts?
tsteur
added
not-in-changelog
I can't say anything about all *nix, but find will work on every Posix compliant (and compatibel) systems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #13628
For not writable directory it generated eg this:
for auto update it also adds execute permission for
consoleNot sure if any other file needs permission to execute? Couldn't think of any right now. Of course the find commands above they don't change the permission of any symlinks or so. Not sure what users possibly have in there and if it could create some issue. Could extend the find command to something like
-type f or -type l.Also generally not sure if
findis compatible like this on all *nix.@Findus23 maybe any thoughts?