Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CronArchive: Catch UnexpectedWebsiteFoundException #14403

Merged
merged 2 commits into from May 2, 2019
Merged

CronArchive: Catch UnexpectedWebsiteFoundException #14403

merged 2 commits into from May 2, 2019

Conversation

paladox
Copy link
Contributor

@paladox paladox commented May 2, 2019

This is to allow the archive to continue if the site was deleted from matomo.

Fixes #14393

@paladox
CronArchive: Catch UnexpectedWebsiteFoundException
7a7269e 
This is to allow the archive to continue if the site was deleted from matomo.

Fixes matomo-org#14393
@paladox paladox mentioned this pull request May 2, 2019
Closed
tsteur
tsteur requested changes May 2, 2019
View reviewed changes
Copy link
Member

@tsteur tsteur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a minor comment but otherwise looked and worked 👍

core/CronArchive.php Show resolved Hide resolved
@tsteur tsteur added this to the 3.10.0 milestone May 2, 2019
@tsteur tsteur merged commit c9f70ee into matomo-org:3.x-dev May 2, 2019
@paladox
Copy link
Contributor Author

paladox commented May 2, 2019

Thank you! (would this make it into matomo 3.10?):)

@paladox paladox deleted the patch-2 branch May 2, 2019 21:15
@tsteur
Copy link
Member

tsteur commented May 2, 2019

Yes 👍 Cheers for the PR

@paladox
Copy link
Contributor Author

paladox commented May 2, 2019

Thanks!!!

@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur requested changes

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.

Let core:archive continue even if the website was deleted in the meantime
3 participants
@paladox @tsteur @mattab